commit | df591fb571b2c18f2ab818098e2d6ac3014c9560 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Fri Feb 01 15:15:16 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 01 15:15:16 2019 |
tree | c10bbfcdbebe7960af9300e585eaca7a37c6b9d5 | |
parent | abe3264497f5be8c7ce90ca07a09d7b3f1cdd4b4 [diff] |
Compiling headless_shell_switches.cc once should be enough In Windows (multi dll) builds, headless_shell_switches.cc was compiled twice and with some timings and linkers, that cause a duplicate symbol link error. In other cases one set of symbols was discarded as unused before the link errors. This setup was probably triggered by several build target (headless_renderer, headless_shell_browser_lib, headless_shell_child_lib and more) being compiled as if they were inside headless.dll in component builds. That prevented them from actually accessing the switches inside headless.dll. The fix is to only compile headless.dll ("component headless") with HEADLESS_IMPLEMENTATION, which controls HEADLESS_EXPORT, and to not have a duplicate copy of the switches in headless_shell_browser_lib. Bug: 919231 Change-Id: Id0d5cade84b47b9053474a26a1b14723c576d346 Reviewed-on: https://chromium-review.googlesource.com/c/1440141 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#628335}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .