Google Git
Sign in
chromium / chromium / src / df5e2cc33a579c47e6242a808195437092b2f344
commitdf5e2cc33a579c47e6242a808195437092b2f344[log] [tgz]
authorMoe Ahmadi <mahmadi@chromium.org>Wed Jul 11 19:53:45 2018
committerCommit Bot <commit-bot@chromium.org>Wed Jul 11 19:53:45 2018
treeeb4dd47bdb9c042e946a94546417d43685ab52bb
parent4f799497909efb1abf363546de886bfa71c0025a [diff]
[AF][IOS] Takes secondary toolbar into account in CC save infobar (Part 2)

This CL moves the logic to set the infobar's bottom margin from
|-layoutSubviews| to |-sizeThatFits:|. The former method doesn't
always get called after the secondary toolbar disappears in
landscape mode. The latter does get called more reliably in both
portrait and landscape modes.
Also provides comments on why |-setFrame:| is overridden.

Bug: 849433
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3ce410378d60535178a0c0c9d0f12f11948772ba
Reviewed-on: https://chromium-review.googlesource.com/1112303
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574291}
1 file changed
tree: eb4dd47bdb9c042e946a94546417d43685ab52bb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .