commit df5ed26173f1af22eb80d06960f582a75f2d5835
author Daniel Cheng <dcheng@chromium.org> Sat Oct 01 02:34:30 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Oct 01 02:34:30 2022
tree 45a8ae4fdf1cc746b7b81e5e0abd2c2773d0e3f6
parent 9cfd01a62fc0b97005bb73a0fcde8a403df299f3

Use helper macros to define base::Features in //chrome

This allows:
- features to be defined with a consistent set of qualifiers, and for
  that set of qualifiers to be updated over time as appropriate.
- better PRESUBMIT checks to ensure that base::Features are not defined
  in headers.
- simplifies things for scripts trying to extract feature definitions
  out of C++ code.

The primary CL was generated using a script that automatically rewrites
base::Feature declarations and definitions to the macro form. Changes to
any files with known incompatibilities with the macros (base::Features
without static storage duration and base::Features declared as static
class members) were then fully reverted; those changes will be manually
handled in followups.

This is an automated cleanup pass to fix up new stragglers before
enabling stricter enforcement.

Bug: 1364289
Change-Id: I11807cac7b75807f1d57d90d19d7ff5db3b37678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931406
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1053864}