commit | df7168cf8179a10295caf128237e76dad9c56a7f | [log] [tgz] |
---|---|---|
author | Friedrich Horschig <fhorschig@chromium.org> | Fri Nov 18 13:41:04 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 18 13:41:04 2022 |
tree | 8ec04d3de81b42f00aff05b7aadea022a862aac4 | |
parent | 6c06874c6d6eb0a06a72d02f6b335a6893e31697 [diff] |
Reland "[Android][Mfill] Scroll focused input into view to prevent overlap" This is a reland of commit 129018318ba8dd9c251c5d793415e763b843b617 Original change's description: > [Android][Mfill] Scroll focused input into view to prevent overlap > > The renderer scrolls the focused input into a visible space as soon as > the keyboard appears. At that time, it's still unclear whether the > accessory will be visible. > Therefore, the accessory will request to center the view once it's fully > visible. If the input is already visible, this call is a noop. > > Video of the new scrolling behavior: > https://drive.google.com/file/d/14P1yTomfxxDxmB4uL49W5NpRhI0qHWMu/view?usp=share_link&resourcekey=0-J4jysc_64U5OGR40yea7TA > > This CL cleans tests that it touched: > * prefer to select tabs by description (more stable than index) > * remove redundant isDisplayed (whenDisplayed uses that matcher) > * scroll to TabLayouts before clicking them (to make sure they exist) > > Bug: b/254911004 > Change-Id: I91eeb872480bdd636e6d81f2b5d7abd7d1dc3e12 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020136 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1072741} Bug: b/254911004 Change-Id: I107761b16db49d6cdc67dba3c6c3f531aa6d3ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4037761 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1073339}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.