| commit | df83aa3ad4de5283314e29655e06fdf812e636c9 | [log] [tgz] |
|---|---|---|
| author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Tue Nov 14 15:53:14 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 14 15:53:14 2023 |
| tree | e012c8880769d0e798b4e9244bb5b321b12bc75f | |
| parent | 21d95006268c8e91b848007ee0a0f8afaff74f37 [diff] |
Revert "Enable WebAssembly trap handlers for AArch64" This reverts commit 520c335469de0d01b2666a4c4ae321fd12b63423. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8764439140677950945 Sample failed build: https://ci.chromium.org/b/8764439140677950945 If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8764439140677950945&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5028657 Original change's description: > Enable WebAssembly trap handlers for AArch64 > > The use of trap handlers for WebAssembly OOB accesses have been > enabled in V8 for a while. The chromium tests had already been > updated to handle the change when testing a simulator build, and this > patch finally flips the switch to enable the feature. > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng > Change-Id: Ife085d435ca28b100e9b16e4e985447c90aa9faa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5028657 > Commit-Queue: Andre Kempe <andre.kempe@arm.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1224295} > Change-Id: Iae5e97792cd1662d52ea5113cfe86383e1beb282 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5027490 Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1224304}
diff --git a/content/renderer/render_process_impl.cc b/content/renderer/render_process_impl.cc index e91dd2ac..be1f39d 100644 --- a/content/renderer/render_process_impl.cc +++ b/content/renderer/render_process_impl.cc
@@ -224,8 +224,7 @@ v8::V8::SetFlagsFromString(kSABPerContextFlag, sizeof(kSABPerContextFlag)); } -#if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && \ - (defined(ARCH_CPU_X86_64) || defined(ARCH_CPU_ARM64)) +#if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && defined(ARCH_CPU_X86_64) if (base::FeatureList::IsEnabled(features::kWebAssemblyTrapHandler)) { base::CommandLine* const command_line = base::CommandLine::ForCurrentProcess();