Google Git
Sign in
chromium / chromium / src / dfb9023b74910a48aa7fb5b4ec196726f03a214e
commitdfb9023b74910a48aa7fb5b4ec196726f03a214e[log] [tgz]
authorTrent Apted <tapted@chromium.org>Wed Sep 16 00:04:31 2020
committerCommit Bot <commit-bot@chromium.org>Wed Sep 16 00:04:31 2020
treef8dce8beda3f5fe1f30334c6247e99097bc8ff4f
parenta490512e82e214c882d97ea4927b9cf58cccc9bc [diff]
Run some MediaApp integration tests with guest and incognito profiles.

The AppService presents itself to the system differently in these
profile configurations, which has resulted in subtle crashes.

This CL configures SystemWebAppManagerBrowserTest with a third gtest
parameter type. It "defaults" to TestProfileType::kRegular and
establishes a way for system apps to neatly specify a set of their
tests that should have coverage for all profile types.

Bespoke tests for the HelpApp are migrated to this setup, and a subset
of pertinent MediaApp tests are parameterised for profiles.

Verified the desired coverage is satisfied by commenting out code
in web_file_tasks.cc that fixed things that have crashed in the past.
E.g. Unconditionally doing `profile = profile->GetOriginalProfile()`
causes 6 of the guest mode tests to crash, and omitting that completely
causes DCHECK(..IsAppServiceAvailableForProfile) to fail for the
incognito tests.

Bug: b/166730281
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I22e7062eab0d4d21329602ec27afba89197e7c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398450
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Rachel Carpenter <carpenterr@chromium.org>
Reviewed-by: Jiewei Qian  <qjw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807259}
10 files changed
tree: f8dce8beda3f5fe1f30334c6247e99097bc8ff4f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.