commit | dfbab00565f95be6909ba7655eb44af7c68cf8a2 | [log] [tgz] |
---|---|---|
author | Nigi <nigi@chromium.org> | Mon Aug 21 22:35:34 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 21 22:35:34 2023 |
tree | a3b6e2eec678dcbcf69190f47b2b345613df4f2e | |
parent | ff602be4042c8638b2238f5235d3bbd6ad5871fa [diff] |
Revert "Dictation: Show toast when toggling Dictation fails" This reverts commit ece65e4b98ac17e1f8767555ded8fd2d78258d10. Reason for revert: This CL might the culprit that caused browser_tests failure: NetworkDictationKeyboardImprovementsTest/DictationKeyboardImprovementsTest.ToggledWithNoFocusTriggersSpeech. The earliest failure can be found at: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/37926/overview. Original change's description: > Dictation: Show toast when toggling Dictation fails > > This change implements the behavior described in slide 7 of the UX > mocks [1]. When Dictation fails to toggle because there is no focused > text field, we now show a toast that explains why Dictation failed. > To do this we: > > 1. Added accessibilityPrivate.showToast(), so that the dictation > extension can request the toast to be shown. > 2. Added AccessibilityNotificationController, which manages showing > the toast. > > [1] https://docs.google.com/presentation/d/1mRnYcRpyzbY-EjzptCP3KRB5I7v_rM9Kl2zqhhQVZUY/edit#slide=id.g24cce1f4158_0_12 > > Bug: b:259352600 > Change-Id: Ib576ce89385fca52132ea55811ac5f0972faa8ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4705046 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Mark Schillaci <mschillaci@google.com> > Commit-Queue: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1185921} Bug: b:259352600 Change-Id: Iae3ae5164b709b3a22f1f68d224755453a06b662 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798865 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nigi <nigi@chromium.org> Owners-Override: Olivia Yingst <huiyingst@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1186108}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.