commit | e001708a730fa4a9963070aac1dc52994e243d82 | [log] [tgz] |
---|---|---|
author | Colin Blundell <blundell@chromium.org> | Wed May 28 07:19:51 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 28 07:19:51 2025 |
tree | 2020190ba58eb47066558b32735dcf794c450dfc | |
parent | 3696ab6143470ec2a9c31bfbe35a7d1cbc4cbfd9 [diff] |
[Blink] Massage WebGL {Pre, Post}FinalizeFrame() flow The objective here is to get the GetOrCreateCanvasResourceProvider() calls and the PaintRenderingResultsToCanvas() call all directly next to each other in HTMLCanvasElement::PostFinalizeFrame(). PreFinalizeFrame(), CanvasRenderingContext::FinalizeFrame(), and PostFinalizeFrame() are all (and only called) directly in a row [1], so this can be done by just moving the code to all be in PostFinalizeFrame() in the same order as it is currently. This unlocks followup refactoring of this flow to avoid having it talk in terms of CanvasResourceProvider for low-latency WebGL. Note: `did_print_current_task_`, which is cleared between the calls to FinalizeFrame() and PostFinalizeFrame() [2], is not read in PostFinalizeFrame(); outside of its read earlier in `DidProcessTask()`, it is read only in a Canvas2D-specific method here [3]. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc;l=108-118;drc=70343319512a4883095fdb100796ea70fba34b9e;bpv=1;bpt=1 [2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc;l=115;drc=70343319512a4883095fdb100796ea70fba34b9e [3] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/html_canvas_element.cc;l=380;drc=70343319512a4883095fdb100796ea70fba34b9e;bpv=1;bpt=1 Bug: 352263194 Change-Id: I57e85026367c11783edc9af796f0066c0013d69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6592180 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#1466330}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.