commit | e02cf2c03edc5120fb724f2b5df45b496a5392ee | [log] [tgz] |
---|---|---|
author | Andreu Botella <abotella@igalia.com> | Wed Jan 25 04:26:17 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 25 04:26:17 2023 |
tree | e355ad57c3838a4c8cef41a77e1acc5a8b621698 | |
parent | 56a52d66b15a1a3937390a99e5e573a46a7fa8ab [diff] |
Fix line breaking with `break-spaces` in the presence of close tags With the `white-space: break-spaces` CSS property, white spaces are always preserved, and they always take space. Combined with the fact that white space characters have a break opportunity after them, but not before (as required by UAX#14), this means that a word which exactly fits the remaining inline size of the line, could not fit in that line without overflow if it was followed by a space. Chromium's implementation of `break-spaces`, however, did allow breaking between a word and a space if there was a closing element boundary in the way, even if both sides of the boundary had `white-space: break-spaces`. This is because `NGLineBreaker::HandleCloseTag` did not seem to be considering the `break-spaces` class. This CL fixes this. Bug: 1261435 Change-Id: I010cf99ffb0c2cf03b4ff2547a412cc44c7e1bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4150327 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1096617}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.