Google Git
Sign in
chromium / chromium / src / e08093dc66512c3b822d9a3b072ca6a6bcb4cfe2
commite08093dc66512c3b822d9a3b072ca6a6bcb4cfe2[log] [tgz]
authorAvi Drissman <avi@chromium.org>Mon Mar 17 01:50:41 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 17 01:50:41 2025
treec8d6d76b8db5166442c6f22753afb584105cf097
parentb74b0b68ffc09b5c94297fcc05fa0cd8d055db69 [diff]
Do popup modernization without switching to the new API

https://crrev.com/c/6173642 switched to new API for doing popup menus,
but it also did some associated cleanup. While the new API was buggy
(see https://crbug.com/401443090) and therefore had to be reverted, the
cleanup aspects are still a good idea, so re-land them.

Specifically:
- Switching WebMenuRunner to have explicit testing callbacks rather
  than requiring other code to swizzle NSView with the knowledge of
  the WebMenuRunner internals.
- Removal of the "useWithPopUpButtonCell" parameter on
  MenuControllerCocoa, which was not actually used for
  PopUpButtonCells! (The WebMenuRunner builds its own menus.)
- Removal of the default -init on MenuControllerCocoa due to having no
  callers; now MenuControllerCocoa always eagerly builds the menu,
  simplifying things.
- Light code modernization.

Bug: 389067059
Include-Ci-Only-Tests: chromium.mac:mac14-tests|browser_tests
Change-Id: If62fd54001c9ad2c50e6bd96a97c894b00a7bc61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351721
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1433321}
15 files changed
tree: c8d6d76b8db5166442c6f22753afb584105cf097
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.