commit e0dbccde31b18c40fc833cf04393a04d146c9006
author Javier Contreras Tenorio <javiercon@microsoft.com> Thu May 22 21:39:02 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 22 21:39:02 2025
tree 122aa6945364b9f4f243efc57ebb2a16ab745cdf
parent 03bcb25623c9f837359dee9ea29e4bafbf6bcd93

[gap-decorations] Properly parse !important in for gap *-rule shorthands

This CL makes it so we correctly parse gap rule shorthands that include
the `!important` token. In order to achieve this, we break early in our
shorthands parsing logic rather than returning false as soon as we fail
to `attemptToConsumeValue` in the loop, since we could be in the
situation where `consumed_any` is false after first correctly parsing
some gap rules and left in the stream we just have `!important`.

We now only return false if we have not consumed any style, width, or
color.

For instance if we have `column-rule: 5px solid red !important`, the
last iteration of the loop will try to parse `!important` which will
fail and `consumed_any` will be false.

This way, we defer the normal pipeline to try to consume the important
token if one exists.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/parser/css_property_parser.cc;l=170?q=MaybeConsumeImportant&ss=chromium

Bug:357648037

Change-Id: Id2f9d35978bc4a71d8211ca9c722ca0ba1431bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6563907
Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Javier Contreras <javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1464371}