commit | e10543e7eb88e08605bc727186e2afb5db6717c0 | [log] [tgz] |
---|---|---|
author | Valerie Young <spectranaut@igalia.com> | Mon Mar 17 17:38:14 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 17 17:38:14 2025 |
tree | e6c52364497c19cc2504d03f85c86825fed196ef | |
parent | f19aa941cc81ad26fc710120c7f3afd25dbb5ca3 [diff] |
[Select to Speak] Update extension to MV3 manifest List of changes: * Create an off screen document to handle DOM interactions: * playing the null selection tone in select_to_speak.ts * google docs specific logic in input_handler.ts * Removing the use of eval from a content script and hard coding the extension ID instead. * Replaced deprecated API end point chrome.tabs.executeScript * Add KeepAlive class * Use MV3 InstanceChecker Testing: * Basic testing of select-to-speak * Null selection did not work before (https://issuetracker.google.com/issues/398728543), but I confirmed that null tone can be heard by calling `chrome.runtime.sendMessage(undefined, {command: 'playNullSelectionTone'});` directly. * After turning on select-to-speak and opening a google doc, the text of the google doc can be selected and spoken with text to speak * If the google doc is already open and select to speak is turned on, the google doc text will not be spoken, bug filed here: https://issuetracker.google.com/issues/399093287 * I was not able to test google docs specific logic in input_hanlder.ts because of a pre-existing bug: https://issuetracker.google.com/issues/400335369 Bug: 388867837 Change-Id: I375fc3f7ce71445e65722d366ec910b4be6b1819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6324769 Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Valerie Young <spectranaut@igalia.com> Cr-Commit-Position: refs/heads/main@{#1433622}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.