| commit | e1653d3073e955fa4866deed1658470e9e31b857 | [log] [tgz] |
|---|---|---|
| author | Erik Anderson <Erik.Anderson@microsoft.com> | Fri Nov 15 18:20:10 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 15 18:20:10 2024 |
| tree | dd9aea311bfb27f407ae09ff3cf80a13a2b4bba4 | |
| parent | 7288ca49f4b10bd0c4455fe781d27b6514aba72f [diff] |
Media engagement autoplay browser tests: fix python3 path on Windows for all embedders. On Windows, it's not guaranteed that `python3` without an extension will find a working copy of Python. Windows provides a stub executable that can help redirect to the Microsoft Store to get a copy there; in these environments the test fails with a difficult-to-understand error. `vpython3.bat`, with the extension, however, always exists. This change allows these tests to pass in Microsoft Edge's engineering system. Note that Chromium has a history of issues where Python was not consistently available across environments. For example, /net/test code attempted to solve this by wrapping it in a "cmd /c" call here: https://codereview.chromium.org/876633004/diff/40001/net/test/python_utils.cc That logic was later removed when those tests were migrated to vpython: https://chromium-review.googlesource.com/c/chromium/src/+/874153 Change-Id: I836660f69d30819e2b5c0afbf8ba8eac00994123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6023809 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Erik Anderson <Erik.Anderson@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1383700}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.