commit | e174a4692ec62ecbc16c1d7e187a68ece36e8013 | [log] [tgz] |
---|---|---|
author | Abhijeet Kandalkar <abhijeet@igalia.com> | Fri Jul 02 16:31:19 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jul 02 16:31:19 2021 |
tree | 2f640893f3a926e92a7031b831ec8d6918a7ac03 | |
parent | 20200bb245b9f5cd6a9f3d74d93e531dc8b63224 [diff] |
[lacros] Handle initial windows state as minimized What is an issue ? 1. lacros-browser sends a request to create a toplevel surface. 2. lacros-browser sends a request to minimize toplevel surface. 3. For point 1, exo triggers a configure callback with an empty suggested size and a widget is not created for a toplevel surface. Here, exo is waiting for a lacros-browser to configure windows bounds. 4. For point 2, as the widget doesn't exist the minimized request is cached on the exo side and will be applied to future surface commit 5. As mentioned in point 3, as bounds are empty, lacros-browser doesn't call a surface commit and widget never created. This CL added implementation, - on lacros-browser side to configure window bounds and commit the surface. - on exo side, it breaks configure callback loop by forcing creation of widget when |initial_show_state_| is minimized. Bug: 1189981 Change-Id: I0b66dfa5e4ccfe26267e4d4b595bb7058af152ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2945261 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Maksim Sisov <msisov@igalia.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#898207}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.