Google GitGoogle Git
Sign in
chromium/chromium/src/e18088d4e2f84284aeaa391fc3bb1df2a4f96e60
commit
e18088d4e2f84284aeaa391fc3bb1df2a4f96e60
[log]
author
Yuki Yamada <yukiy@chromium.org>
Wed Dec 01 04:58:26 2021
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Dec 01 04:58:26 2021
tree
ba54dad5931c95c53d89131b4c3bbb340859bf61
parent
3656cf8880e144520fb7f74613de6a91d271a001 [diff]
BRP: Add NO_STACK_PROTECTOR to raw_ptr methods

Following glazunov@'s idea [1], this add NO_STACK_PROTECTOR to raw_ptr
methods. It is necessary to convert ContentMainRunnerImpl::delegate_ to
raw_ptr. See the linked bug for more details.

The same method with CheckedPtrNoOpImpl Performance Change doc [2]
didn't find anything strange with this change at lease in chrome/ and
content/.

[1] https://crbug.com/1274129#c5
[2] https://docs.google.com/document/d/1f5Xv-zVHN1JUotjePvZ5jN6and8RxqHnXDu0esZr3rk/edit?usp=sharing

Bug: 1274129
Change-Id: Ia3d0ab484be4c08b67377368d81df7da0e98773c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305993
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#946866}
1 file changed
tree: ba54dad5931c95c53d89131b4c3bbb340859bf61
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.