commit | e18c0ea652180949b76464b9b4f31642aa0437f4 | [log] [tgz] |
---|---|---|
author | Alexander Cooper <alcooper@chromium.org> | Tue Sep 17 00:09:39 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 17 00:09:39 2024 |
tree | cd420f7e8b889f78b530d9aba9328ea0c451e6b0 | |
parent | 971c86a85e2493b00979a2fd5c5e62cd0db8d04c [diff] |
Infrastrucutre for plumbing test hand joint data Adds infrastructure to plumb hand joint data from tests into runtimes. Unfortunately, this bumps the `ControllerFrameData` past the heuristic where it is now "Complex" and needs explicit out-of-line constructor, destructor, copy, and move operators. This in turn exposed some less- than-ideal build configurations which are now cleaned up by way of a new test hook component. In order to decrease dependency on vr_service, XRHandJointData was moved to its own mojom file as well. This uncovered an unneeded dependency from vr_service onto browser_test_interfaces.mojom, which could now be removed. It does also appear that the vr_test_hook's usefulness is perhaps somewhat questionable, as both the actual tests and test hook wrappers translate from mojom types into test_hook types. We should really investigate either typemapping or simply using the mojom types directly, but attempting to do so quickly unveiled a lot of patterns that would need to be cleaned up that were out of the scope of this CL, which is aiming to add infrastructure to allow some basic tests that plumb up hand joint data. Bug: 359418633 Change-Id: Ib60f6c8ed9c420e481bb4d0d69ea30dc00f3374f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5847889 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#1356216}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.