Extract Textfield touch selection dragging into helper functions.

To make the logic in Textfield::OnGestureEvent a bit easier to follow,
move the touch selection dragging parts into helper functions. This
should help make the behaviour of selection_dragging_state_ and
selection_dragging_offset_ easier to understand since they are now only
used from the new helper functions.

Also add helper functions for touch scrolling to make it clearer how
touch selection dragging interacts with touch scrolling.

For reference, see how Textfield::OnGestureEvent looked before
selection dragging logic was added:
https://source.chromium.org/chromium/chromium/src/+/refs/tags/109.0.5414.85:ui/views/controls/textfield/textfield.cc;l=740;drc=ca87d6400e87419e0eaf902a1004c17c0430c4fa

Later, we could also consider moving the selection dragging code into a
separate class (or possibly combining some parts with
views::TouchSelectionControllerImpl or views::SelectionController).

Bug: b:244116654
Change-Id: I552ee1dabe93c3a077b86ba5ce36e21540bedf14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592756
Commit-Queue: Michelle Chen <michellegc@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156774}
2 files changed
tree: b2359d99274413d7bd479855e3f85bcf8e8f624b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.