commit e1d141d72688ac0a85547c21def5541140fbe967
author Yoshisato Yanagisawa <yyanagisawa@chromium.org> Tue Dec 10 12:41:17 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 10 12:41:17 2024
tree 6a64e99f4622847ad21e22f1a88fd4fbc6b4ad4f
parent 2f996375993c47a9d30869784833ff3167d4d018

Revert "Inherit service worker controller for srcdoc iframe"

This reverts commit f0232ec8df7029a085dd1fac1c9af57eaa52cbab.

Reason for revert: this CL might cause crbug.com/382895651 crbug.com/382895896 because the origin of srcdoc client may not be the origin of controlling service worker script origin.

Although there is a follow up CL (crrev.com/c/6081248) that may fix the issue, I prefer to revert the possible root cause before applying it so that easy to distinguish the root cause.

Original change's description:
> Inherit service worker controller for srcdoc iframe
>
> Same origin srcdoc iframes should be controlled by the same service
> worker that controls the parent frame.
>
> To achieve this, we expand ServiceWorkerClient::InheritControllerFrom to
> also support srcdoc and about:blank iframes and use it to setup service
> worker client for srcdoc frames when NavigationRequest for them is to be
> committed. Not that while InheritControllerFrom is updated to also
> support about:blank iframes, this change is only for srcdoc iframes.
> about:blank iframe navigation is committed synchronously and requires
> separate fix.
>
> To allow these clients to show up in clients.matchAll, we update same
> origin check in GetWindowClients to use GetLastCommittedOrigin instead
> of GetLastCommittedURL of the frames.
>
> As the srcdoc frame test in about-blank-replacement.https.html now
> passes, update expectation to reflect that.
>
>
> Bug: 41411856
> Change-Id: I2c464bd7c0e9e8bdf656ad24aeef631fae5a3a31
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054691
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Commit-Queue: Liang Zhao <lzhao@microsoft.com>
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1393072}

Bug: 41411856, 382895896, 382895651
Change-Id: Iac2d99aab1f2273e87089053468c8c520d6077e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6083273
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1394212}