Google Git
Sign in
chromium / chromium / src / e1e02fde482ca40c13f2029aee27b67b2de1acea
commite1e02fde482ca40c13f2029aee27b67b2de1acea[log] [tgz]
authorCollin Baker <collinbaker@chromium.org>Wed Mar 26 16:40:16 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 26 16:40:16 2025
tree6b3c03c49debb4665a51d00799618d4719c8b6ca
parent7f1286ee4f81d5bda18e3f0daee51ba2cbd41af6 [diff]
Revert "Pass filename as rust::Str from Rust log interface"

This reverts commit dcbe3bad14977a4e453b5cfdcb680d3236e0613e.

Reason for revert: crbug.com/406443772

Original change's description:
> Pass filename as rust::Str from Rust log interface
>
> Removes the last heap allocation from the Rust log adapter: instead of
> copying the string provided by the log library to a C-compatible
> string, pass the string slice directly through cxx.
>
> Bug: 371112531
> Change-Id: I163051fa8e34d61494b47ab3a01ed752757ea3c7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6384137
> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> Commit-Queue: Collin Baker <collinbaker@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1438152}

Bug: 371112531
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8e8aba38cb075bb4e1ce45dc373c8e1700e038ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394768
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438192}
3 files changed
tree: 6b3c03c49debb4665a51d00799618d4719c8b6ca
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.