Fix HttpRequestInfo::upload_data_stream dangling pointer, try 2. HttpStreamFactory::Jobs and HttpStreamFactory::Controllers keep pointers to HttpRequestInfos. These jobs can outlive the parent request when they're orphaned (That is, when we keep an HTTP/3 Job around after we have an HTTP/2 connection, so we'll have an HTTP/3 connection available if there's a new request that can use one down the line). That causes the `upload_data_stream` to dangle, if we orphan a job when there's an upload body. To fix this, create a new HttpStreamFactory::StreamRequestInfo structure, which is just the portion of HttpRequestInfo that's needed by the stream layer, and create copies of that instead for the ::Job and ::Controller. This also saves a bit of memory, since we're no longer needlessly creating copies of the request headers, among other fields. Bug: 40212619 Change-Id: I4594c5517e565efed92f241a5bb1a0dce6777008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420153 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: mmenke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#1282241}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.