Change how CopyMainAndPopupFromSurface computes drop-down offsets RenderWidgetHostViewBase::CopyMainAndPopupFromSurface was using GetBoundsInRootWindow() to get the offset of the window and drop-down. Unfortunately, despite the name, GetBoundsInRootWindow() actually gets the bounds of the top-level view, not this view. This caused drop-down windows to be drawn in the wrong place on screenshots. We fixed this issue by calling GetViewBounds() instead. Bug: 450618828 Change-Id: I90c2b0636f0c0eedb2771c7a6e8e3e111153e4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7031505 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/main@{#1529622}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.