commit e2be711443aa39f40a3c7e2f126f3cc4a3a1015f
author Toni Barzic <tbarzic@google.com> Wed May 08 08:11:57 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 08 08:11:57 2024
tree 86d7b2baaa0e1b2013c7a5fd77018d567df453bb
parent 2d895ae0642c2c0cb9408e8570da4b9cfbfca559

Use holding space image in file search

Makes launcher file results return an ImageSkia that lazily loads the file thumbnail image. This ensures that file result thumbnails are
loaded only when needed. Previously, thumbnails were requested for
every available file result, causing jank for queries that returned
large number of file results. To manage icon loading, reuses existing
`HoldingSpaceImage`, which solves the same problem in holding space UI.

File results are expected to display a placeholder, file type icon while
thumbnail is loading, which `HoldingSpaceImage` supports. Some
adjustments were needed for file results for image search - in this case
the UI shows a "pulsing" block animation in place of the icon. This was
achieved by search provider returning results with an null icon until
the thumbnail image was loaded. This does not work with the new
approach, as now FileResults return a non-null lazily loaded image.
This adds "is_placeholder" param to the result icon info, which can UI
uses to determine whether pulsing blocks need to be shown beneath
the result image view showing a placeholder image (which is set to an
empty image for file results for image search).

BUG=b/333648341, b/324083876

Change-Id: I995a1cfc6226830208b8ea7d4b49f2f194528a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503952
Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: CJ Huang <chenjih@google.com>
Cr-Commit-Position: refs/heads/main@{#1297993}