commit e2e739e6e3d562578af11704fb8a8118cfd5dbd2
author Victor Costan <pwnall@chromium.org> Thu Aug 26 14:42:25 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Aug 26 14:42:25 2021
tree 2bd72fcbad6269f0f751fc962542d2c8e9792ccb
parent 36a191a239b8787d2ae118f4595e6ca39d833989

Font Access: Extract functions in Windows implementation.

The main goal of this CL is to make ExtractNamesFromFamily() in
//content/browser/font_access/font_enumeration_cache_win.cc smaller, and
therefore easier to read.

* COM interface function arguments that are only used during the
  function call are passed using raw pointers, instead of
  Microsoft::WRL::ComPtr smart pointers. This is similar to limiting the
  use of std::unique_ptr and scoped_refptr to arguments that are stored
  and used past the function call.

* GetNativeString() is folded into GetLocalizedString(). A key
  observation here is that, before this CL, GetLocalizedString() was
  only used for `full_name` (lines 176-179), and the two calls
  effectively implemented the same fallback logic used in the old
  GetNativeString() implementation. So, GetLocalizedString() now
  implements the fallback logic, and is used everywhere.

* For uniformity, GetLocalizedString() is updated to take a raw pointer
  to the IDWriteFont COM interface, instead of a Microsoft::WRL::ComPtr
  smart pointer. This is appropriate because GetLocalizedString() only
  uses the argument during the function call.

* GetSystemFonts() contains the logic that used to live at lines
  257-272 before this CL.

* GetFontInformation() contains logic that used to be duplicated at
  lines 143-151, 164-171, and 185-193 before this CL.

* GetFamilyName() contains the logic that used to live at lines 106-114
  before this CL.

* GetFontPostScriptName() contains the logic that used to live at lines
  134-154 before this CL.

* GetFontFullName() contains the logic that used to live at lines
  162-180 before this CL.

* GetFontStyleName() contains the logic that used to live at lines
  183-209 before this CL.

* Lines 211-213 before this CL were inlined in lines 269-271.

Bug: 1232812
Change-Id: Ie0e5a001bf6faf676a0188b906bb60a8ab0102f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3105730
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#915573}