Google Git
Sign in
chromium / chromium / src / e2f115e37e39582a94031c46fe0fb17182b147e9
commite2f115e37e39582a94031c46fe0fb17182b147e9[log] [tgz]
authorJonathan Lee <jonathanjlee@google.com>Wed Feb 15 22:02:53 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 15 22:02:53 2023
tree639bd35d817881a217110291440bab663a464e78
parent69030c4b7f0f937b95a1842e99922d62741e1333 [diff]
[wptrunner] Default to `--headless`

wptrunner's `--headless` defaults to `None` (i.e., falsy), whereas in
`run_wpt_tests.py` it should default to `True`. crrev.com/c/4244463
neglected to override the default; this change is the forward-fix.

Running Chrome without `--headless` manifested as widespread timeouts,
but usually only on each tests's initial run [1].

[1]: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-wpt-fyi-rel/39306/overview

Bug: 1368679, 1356318
Test: `run_wpt_tests_isolate -t Default css/CSS2` has no timeouts
Change-Id: Ie6837abdc75f12c0da73d4d3c8f1fcf986b081be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4256848
Auto-Submit: Jonathan Lee <jonathanjlee@google.com>
Commit-Queue: Weizhong Xia <weizhong@google.com>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1105896}
1 file changed
tree: 639bd35d817881a217110291440bab663a464e78
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.