| commit | e31d4fe1bdde074fd50874862cf718b4898c20fd | [log] [tgz] |
|---|---|---|
| author | Samuel Huang <huangs@chromium.org> | Wed Aug 24 06:22:21 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 24 06:22:21 2022 |
| tree | f2416480522dcef84fe908cca999a1889005bb47 | |
| parent | 78e82cfcff52380a2805c94afdb14b0571c343f8 [diff] |
[SuperSize Viewer] Show {address, padding, object path} in Infocard.
SuperSize Viewer already shows {size (PSS) / counts, alias count,
source path, component, full name, flags} in Infocard. This CL changes
Caspian and the viewer to add the following in the Infocard:
* Address: Displayed like in SuperSize-console, e.g., r@0x12345A, where
"r" is the section code. Hover text shows address in decimal.
* Padding: Shows padding (PSS), which like size, is aggregated
throughout the Tree.
* Object path.
Address and padding are displayed alongside size in the Infocard header.
Details:
* Caspian and Viewer:
* Move code to enforce field order [size, padding, address, flags].
* Caspian:
* TreeNode:
* Add fields padding (float for PSS) and address.
* WriteIntoJson():
* Write objPath.
* Write {padding, address} if non-0; so they're optional.
* TreeBuilder:
* AddFileEntry(): Populate TreeNode.{padding, address}.
* AttachToParent(): Accumulate `padding` alongside `size`.
* Viewer:
* viewer.html: Infocards:
* Split header into 3 <span> elements for {.size-info,
(new) .address-info, (new) .padding-info}.
* Rename .path-info to .details-info.
* Add helpers formatNumber() and formatPercent(), replace existing
usages of string.toLocaleString(), mainly in _makeSizeTextGetter()
and ArtifactInfocard._updateBreakdownRow().
* InfoCard:
* Rename _updateSize() to _updateHeader(); show address and padding.
* _updateDetails(): Show object path.
Bug: 1154515
Change-Id: I53fed5c1237a54eae7d661cf777392047776953c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852523
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1038599}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.