commit e34ac67e83fdbf1aafe6f1c13238293268ceef86
author Prudhvikumar Bommana <pbommana@google.com> Wed Jan 10 18:23:44 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jan 10 18:23:44 2024
tree e2adf4a416cd0718e68fa98df19f850455a6fd44
parent 88fffd6345855b7060912dfef847a2051e002e41

Revert "Prerender: stop prerender from overcounting not triggered failure"

This reverts commit f16e811f86df29d768a63a918676058cef54125b.

Reason for revert: The Cl lead to multiple Browser crashes on latest Canary(crbug.com/1517106,crbug.com/1517137 )

Original change's description:
> Prerender: stop prerender from overcounting not triggered failure
>
> Before this CL, PrerenderHostRegistry records
> BatterySaver/PreloadingDisabled etc every time omnibox receives a new
> input, but this recording logic is not consistent to other final
> statuses. The inconsistent logic results in extremely high failure
> rate in UMA, but that does not really reflect the things we'd like to
> know.
> This CL rewrites this logic. WebContentsImpl::StartPrerendering will
> always creates a new PrerenderHandle instance. For PrerenderHandles
> whose frame_tree_node_id_ is invalid, it means that the prerender
> attempt was rejected by pre-checks. But we keeps this instance alive
> to track the historical attempts.
>
>
> See this document for rational.
> https://docs.google.com/document/d/1a1mlf_JxMD2018bRZtzCR0J0eqFPY_0myBOGdcV12ts/edit#heading=h.7omvz2uyeznq
>
> Bug: 1505293
> Change-Id: I55c6a1d521fdb7fd522a1ce808224cd5720abff1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5069215
> Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: Lingqi Chi <lingqi@chromium.org>
> Reviewed-by: Huanpo Lin <robertlin@chromium.org>
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1244460}

Bug: 1505293,1517106,1517137
Change-Id: I13086d7be746e367b153e3ffad261b91fea2e40a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5186334
Owners-Override: Prudhvikumar Bommana <pbommana@google.com>
Commit-Queue: Prudhvikumar Bommana <pbommana@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1245389}