Use non-sticky BFCache blocking for WebLocks This CL fixes an issue where pages using WebLocks were permanently blocked from the BFCache. Previously, WebLocks was registered as a sticky feature, which blocked BFCache for the page's entire lifetime, even after the lock was released. Now this CL ensures the block is only active while the lock is held. This CL changes the behavior to register the blocking feature only when a lock is granted and unregister it when the lock is released. This CL also updates 2 tests and 3 test expectations: - performance-navigation-timing-lock.https.tentative.window.js: Updated the test to hold the lock indefinitely, fixing a failure where the lock was released too early. - SchedulingAffectingFeaturesTest.WebLocks: Removed since the feature no longer registers correctly in a renderer-only environment and its behavior is already covered by WPTs. - abort.tentative.https-expected.txt - release.tentative.https-expected.txt - report-back-forward-cache-status-details-captured-expected.txt: Switching to a non-sticky feature registration causes the source location to be lost, so the details field is no longer reported. Bug: 434557707 Change-Id: I102e936932e6b7b823fb53babf08e915953ca545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6790586 Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Anna Sato <annasato@chromium.org> Cr-Commit-Position: refs/heads/main@{#1496135}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.