ScrollAnchor: Only allow scroll anchor to be "just off screen"

During scroll anchoring, before layout, we determine an on-screen
anchor and then process the layout and ensure that one of the top
corners (left or right depending on writing mode) is positioned
in the same spot as before. However, this causes problems if the
size of the anchor also changes (with visibility) to be far off
screen. Instead, only allow the anchor to move "just off screen",
with one of its edges touching the viewport area.

This is only applied to content-visibility: auto elements that
have a pending layout.

The effect is similar: the object is moved off screen, but it prevents
unstable behavior with content-visibility: auto.

Note that the intent of scroll anchoring is to keep the visible
contents from shifting. However, in this case the contents are
shifting anyway (since the anchor is off screen), so manipulating
exactly how far off-screen should be ok. It is also limited to
only content-visibility auto elements.

R=chrishtr@chromium.org

Bug: 1138801
Change-Id: I1fbc5f8b634563c770db29bf30ef6d409d810614
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481348
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818681}
7 files changed
tree: 3c8d53c1e15ff6f02f8aefa567a37fa3cbe03a51
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.