Google Git
Sign in
chromium / chromium / src / e3c25144e8d543e15d659b9609c0162eaa40fa11
commite3c25144e8d543e15d659b9609c0162eaa40fa11[log] [tgz]
authorJiewei Qian <qjw@chromium.org>Tue Nov 17 23:34:33 2020
committerCommit Bot <commit-bot@chromium.org>Tue Nov 17 23:34:33 2020
tree7b0f7eb8c51d86ea53118c6b0df9341b16c5475f
parent9b957f69dfd766d433b2744b9916fe45ef866f57 [diff]
system-web-apps: remove expiring bookmark install finalizer histograms

This CL removes two histograms that were used to investigate bookmark
app (extension-based) install failures:
 - Webapp.InstallResultExtensionError.System.Profiles.Other
 - Webapp.InstallResultExtensionDisabledReason.System.Profiles.Other

The relevant code isn't executed after BMO project launch (which moves
SWA install to web app install finalizer).

Also removes the relevant test code that were solely introduced for
testing these two histograms (see https://crrev.com/c/1915651 ).

Fixed: 1149526,1149527
Change-Id: I195f531d7c7a8cf106ed00662e3231d2d2b12b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543531
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jiewei Qian  <qjw@chromium.org>
Auto-Submit: Jiewei Qian  <qjw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828467}
5 files changed
tree: 7b0f7eb8c51d86ea53118c6b0df9341b16c5475f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.