Google Git
Sign in
chromium / chromium / src / e40194e45de0ff67f0581b0a5ced896d6ef28e5f
commite40194e45de0ff67f0581b0a5ced896d6ef28e5f[log] [tgz]
authorDavid Bokan <bokan@chromium.org>Mon Sep 29 16:20:47 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Sep 29 16:20:47 2025
tree1e5fce11bb77607d1f4fba2550989077dd1e62c5
parent2b985eb5da47e1cfa30e68f7b9e7a8bae98a119e [diff]
Actor: Add tests for general page stability monitor

This replaces two disabled flaky tests with a new test harness that more
directly exercises the monitor via the newly added mojo interface. I
wasn't able to repro the flakes and the analysis page no longer shows
any info but this CL tries a few things:

  * Avoid using an actor action (via PageStabilityMonitor mojo) to more
    directly ensure we've started the blocking task.
  * Avoid monitor timeouts.

Also a small fix in the monitor itself: if we're calling via the mojo
interface, the callback must be invoked synchronously. If we post it
then the receiver is torn down immediately after so the callback is
never received, only the disconnect handler.

Bug: b:427619749
Change-Id: I493d746038bf333be70476b41c81d40c06bb7722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6991749
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1522271}
3 files changed
tree: 1e5fce11bb77607d1f4fba2550989077dd1e62c5
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.