Google Git
Sign in
chromium / chromium / src / e4396564324313be9161942af17cdff521b3830e
commite4396564324313be9161942af17cdff521b3830e[log] [tgz]
authorElly Fong-Jones <ellyjones@chromium.org>Fri May 20 17:30:57 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 20 17:30:57 2022
treefe0dc5f7cb3fbd1fd0b011f9e1963535d22dbb06
parent2ace91d8b2e7f32245b10d7abe3a4f06e5a032d7 [diff]
sharing: pass share attempt data through to the sharing hub

This change adds a new type, share::ShareAttempt, which wraps up the
data needed for a single attempted share. This type is currently only
used to store a WebContents and some metadata about it, but it will
shortly be used to store the title, URL, and other information for other
shares (like image or link shares).

The new type needs to be plumbed through:
* BrowserView (regrettably)
* SharingHubBubbleController and its impls
* SharingHubBubbleView
* PreviewView

(cherry picked from commit 2bf11e33cd13baeb5051ad72e4739099fe4fd5bc)

Bug: 1312524
Change-Id: Ic00a34b5b7a56e01ceb1344dd4fcc6666a60dda7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648415
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1004033}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3656474
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#138}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
24 files changed
tree: fe0dc5f7cb3fbd1fd0b011f9e1963535d22dbb06
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.