commit e43977ba587bb0d6357f76a3cbbca937e06ae4c5
author thefrog <thefrog@chromium.org> Mon Nov 18 19:23:22 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Nov 18 19:23:22 2024
tree f79d08f88f5ad844e94d15b5841c27ccd2ee99bf
parent 435f43c75e6953f46276cecb95ee2bdd6cdc9d3e

Make TriggerManager::GetSBErrorDisplayOptions() return smaller struct

Currently GetSBErrorDisplayOptions() returns a large struct of type
security_interstitials::BaseSafeBrowsingErrorUI::SBErrorDisplayOptions.
However, the calls of that method only end up using 3 of the struct
fields.

This CL replaces that function with GetDataCollectionPermissions(),
which returns a smaller struct DataCollectionPermissions that only
contains the 3 relevant fields. TriggerManager methods that used the
struct SBErrorDisplayOptions now use DataCollectionPermissions instead.

The two blocking page classes used a separate BaseSafeBrowsingErrorUI
helper method to thread through a SBErrorDisplayOptions to methods on
the TriggerManager. These helper method calls are left as-is, and the
returned struct is converted into a DataCollectionPermissions after.

Fixed: 345125741
Change-Id: Icf93c4c344fb774b66d93f9e8507fc46772c8387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6026188
Reviewed-by: Zack Han <zackhan@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1384499}