Google Git
Sign in
chromium / chromium / src / e4723d126e1cbc72e579d8e8457d21cd3accf2ba
commite4723d126e1cbc72e579d8e8457d21cd3accf2ba[log] [tgz]
authorAna Salazar <anasalazar@chromium.org>Wed May 18 18:36:02 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 18 18:36:02 2022
treec753cbe47c96942b13a0cbcf8348823a6f0d22dd
parentbb069763d7fae70ec783f1b103565e9ebc57e334 [diff]
[continue-section]: Prevent animating out privacy notice a second time

When the privacy notice animation ends (or is aborted), we update the
visibility of the ContinueSection which results in the deletion of the
privacy toast view.
In an event where the continue section tries to animate the privacy
toast a second time, the first animation will be canceled, resulting in
the view getting deleted and the second animation crashing because an
UAF event.

Exit early AnimateDismissToast() if the privacy notice is already
animating out to prevent deleting the view in this case.

(cherry picked from commit a5b3791615f113bea8405353522ab176c5587e1b)

Bug: 1326237
Change-Id: Ie0823d1e54a01b1611e8881de1d9df57f0565027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649497
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003985}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654260
Auto-Submit: Ana Salazar <anasalazar@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5060@{#85}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
2 files changed
tree: c753cbe47c96942b13a0cbcf8348823a6f0d22dd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.