| commit | e4b64cb76e6fdabb995b8ed3881d1bba1ca5ee00 | [log] [tgz] |
|---|---|---|
| author | Mohamad Arab <arabm@google.com> | Thu Aug 04 15:39:13 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 04 15:39:13 2022 |
| tree | ff971c57bc4e59ace9bb102af608c760cc081938 | |
| parent | 1073ca69e8d3a8527869eb8668fef1ce99023833 [diff] |
Fix crashes when dispatcher is null `getMessageDispatcher()` in some edge cases returns `null`, the code currently doesn't check for that and leads to NullPointerException. This change adds a check and if the return value is `null`, calls the callback function with `false` result and returns the code. The side effect is that user won't see the download dialog anymore and show attempt the download again. Bug: 1343869 Change-Id: Ibea0153f1d72e284f5bd1830d786dd75a7af1c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3804625 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Mohamad Arab <arabm@google.com> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/main@{#1031517}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.