[User Education] Simplify HelpBubbleHandlerBase interface Start by updating the HelpBubbleHandlerBase::GetWebContents() comment. Better explain when GetWebContents() would return nullptr, which is only in tests that are not set up correctly. Offer developers reading the code better advice on what to do in that case. Then follow the updated comment and remove nullptr checks in all the GetWebContents() callers. As a result, VisibilityProvider::CheckIsVisible() can be simplified to return a bool instead of a tri-state. Then delete test code that are no longer applicable. Change-Id: Idbd072bbe09a5190672d6c69ae5721804f663eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7029560 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1528287}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.