Revert "[webgl] Make WebGLObject the owner of the object's ID" This reverts commit de41806ec1b526f30034f342490eca9746fea096. Reason for revert: This CL introduced a DCHECK in blink::WebGLObject::SetObject that is consistently triggered on bots and causes tests to time out because their test pages die. Bug: 413078308 Fixed: 414129877 Original change's description: > [webgl] Make WebGLObject the owner of the object's ID > > Logic to get, set and check the GLuint ID of the WebGL object was > duplicated between WebGLSharedPlatform3DObject and the non-shareable > object, leading to some complexity and additional virtual calls. Merge > all the logic in WebGLObject. This will make it easier to work with > WebGL[Context/Shared/Shared3DPlatform]Object in future CLs. > > Also move IsRenderbuffer/Texture on WebGLObject and remove other unused > RTTI virtual methods. > > Bug: 413078308 > Change-Id: Ie9fbd263b9958007caec0ba744ed300bf3407157 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6485690 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1451655} Bug: 413078308 Change-Id: Iddf1a6c18d721f8ae0750d455376b660afad68f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6494586 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Friedrich Hauser <friedrichh@chromium.org> Owners-Override: Friedrich Hauser <friedrichh@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1452517}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.