Cache top-frame site value in Document to reduce visited links latency

When a blink::Document is constructed, this CL caches the value for top-
frame origin and stores it as a net::SchemefulSite. This has performance
benefits for the new partitioned :visited links model, as each link is
stored as a triple key: <link url, top-level schemeful site, frame
origin>. As a result, for each HTMLAnchorElement found in a Document, we
must perform the relatively expensive conversion from TopFrameOrigin()
to a net::SchemefulSite. By calculating this value once during
construction, we reduce the amount of time spent constructing the triple
key for each link in this Document.

I chose to use a PassKey to limit access to this cached value to
HTMLAnchorElementBase. When working in HTMLAnchorElementBase to
determine the triple-keys for each link, we have certain benefits, such
as a guarantee to be in a frame context where obtaining top-level site
produces a valid, non-null value, and a guarantee that the cached top-
level site will not become stale (if this happens the process is killed
before we could style a link incorrectly). Limiting access to this
function via passkey allows us to safely rely on these benefits.

Finally, from pprof analysis, we can see that this decreases the amount
of time spent in VisitedLinkState::DetermineLinkStateSlowCase by about
0.25%. For more information on why we are working to reduce latency in
partitioned :visited links, visit the bug below.

Bug: 372093900
Change-Id: Ifed3f1c0cb777efb765757b265213f7414962ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5949903
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Kyra Seevers <kyraseevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372040}
4 files changed
tree: 3d06f49688043b4ef465f12fc1ffefd90d695f1e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.