Google Git
Sign in
chromium / chromium / src / e5529d73e1dbadb2b1f932aa79f58aeef94b4b43
commite5529d73e1dbadb2b1f932aa79f58aeef94b4b43[log] [tgz]
authorDibyajyoti Pal <dibyapal@google.com>Fri Feb 23 18:35:11 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 23 18:35:11 2024
tree24a410bce7ff758c0dfcfa6b03a7dd9ec159ba39
parent0dfa4a643450de11a355c286315757141c84424e [diff]
[dPWA] Make the WebAppInstallDialogCoordinator be a WidgetObserver

Instead of using a raw_ptr to a bubble dialog delegate and then using
a WeakPtr to itself everywhere inside the view, the install dialog
coordinator for web apps is now a WidgetObserver. This ensures:
1. Simple lifetimes, since the view inside the coordinator is
tracked only as long as the WidgetObserver is observing the main
dialog, which is more robust than the previous implementation of
a criss-cross raw_ptr, weak_ptr interface.
2. Practices separation of concerns, and brings the implementation
closer to a MVC model, where the behavior, view and its observation
happens independent of each other, with no overlapping logic.

As a side note, this also fixes the measurement of the
WebApp.InstallConfirmation.CloseReason by moving it to a central
location to be used by both the old and new install dialogs.

Bug: b/326418546
Change-Id: I7672d82d1683aa45ce9e51a37d3fef2e1d0c0a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5320614
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1264651}
8 files changed
tree: 24a410bce7ff758c0dfcfa6b03a7dd9ec159ba39
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.