commit | e55cc57a115e86d475cf9647654d508db9077a3e | [log] [tgz] |
---|---|---|
author | Garfield Tan <xutan@google.com> | Wed Mar 12 18:55:06 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 12 18:55:06 2025 |
tree | 8651cdc5fbc46f434708401af9f0d0b33cedb90e | |
parent | bd119533f048022ed7ba9fd449ee399989121b9a [diff] |
device: Stop notifying observers for paired devices on Android Instead, BluetoothAdapterAndroid updates paired devices every time GetDevices() is called. It also updates its device cache synchronously during the process of GetDevices() so its return value contains all paired devices prior to the call. It is OK not to notify observers because Web Bluetooth spec doesn't consider paired states, and Web Serial spec requires Bluetooth devices pairing before opening the dialog. It doesn't strictly match the API spec of BluetoothAdapter, but it only affects rare use cases where devices whose pairing statuses change when a chooser dialog is shown. The notification is unreliable because it stops when the user or the system revokes the permission. Serial chooser also needs to remove options added by OnPortAdded() when options are initialized, because the notification is sent by SerialDeviceEnumerator when a port is added. Bug: 387371131 Test: Both Bluetooth and Serial choosers look OK. Test: device_unittests Change-Id: I15098ae6a948af34c954b40a74f3e079a5b7905d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6341269 Reviewed-by: Jack Hsieh <chengweih@chromium.org> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Garfield Tan <xutan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1431662}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.