Google Git
Sign in
chromium / chromium / src / e572e788cf6d850614b6d4413fbc1657f2b90ddc
commite572e788cf6d850614b6d4413fbc1657f2b90ddc[log] [tgz]
authorRakina Zata Amni <rakina@chromium.org>Fri Jun 11 05:28:50 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 11 05:28:50 2021
treeaa94cec0bfb8700c1b9b35475cee6c35cb6a63fb
parentbb15b25e106a19ab362c7ca7ef3c7bf067c9b995 [diff]
Always replace on iframe synchronous about:blank commit

The synchronous about:blank commit should only happen when the frame is
currently showing the initial empty document. Since all navigations
that happen on the initial empty document should result in replacement,
this CL makes sure all synchronous about:blank commit that happens
at frame creation in HTMLFrameOwnerElement::LoadOrRedirectSubframe()
will use kReplaceCurrentItem. (Previously, the frame load type can be
set to kReloadBypassingCache when the frame is reloaded, setting the
DidCommitParams' should_replace_current_entry to false, and causing a
DwC hit in VerifyDidCommitParams).

Bug: 1204981, 1215096
Change-Id: Id96220c794a5c0fbe84ad0b4127165d6a7ce4e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2945251
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891537}
3 files changed
tree: aa94cec0bfb8700c1b9b35475cee6c35cb6a63fb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.