commit e57fb9d3a03c8bb9ef840fb45f59d672d47c2912
author Alexander Cooper <alcooper@chromium.org> Tue May 06 21:16:26 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 06 21:16:26 2025
tree c05cf499ce6b1bc1b4062043247098362c6a4346
parent da99b406840dfb988aed33e0d050a6add175bfb4

[CodeHealth] Improve LightEstimation spanification

We should not be building RGB Tuples in place, as the compiler can
theoretically add additional padding to these structs (although we'd
likely catch it with the static_asserts). This change moves to a safer
pattern of actually constructing the RgbTupleF32's from the discrete
values, through use of some spans to ensure things are safer.

Further, RgbaTupleF16 is plumbed across as a bag of pixels and then set
as the backing data for a WebGL texture. These textures are small at the
moment, but could grow in size. As such, RgbaTupleF16 is removed and the
arrays are treated as a generic pixel array like for any other image.
This leads to some simplification when conversion is necessary.

Change-Id: Ia4d5529e4148dc763568e35c684054b4c342c56c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6139210
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1456610}