commit e611cd74ca2bed79ce59661427107e07c1b2d4a2
author Marc Treib <treib@chromium.org> Wed Dec 02 10:15:07 2020
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Dec 02 10:15:07 2020
tree 8679e530fe5733762a29fc4e272759625a761020
parent eb247e5a6e8ea4ff188b1861d0bdafe09b53f0c1

DataTypeManagerImpl: Remove "done" logic from StartNextAssociation

...and instead handle it in DownloadCompleted (one of the two call sites
of StartNextAssociation, and the only one at which we can be done with
configuration).

This introduces one behavior change: The set of "requested types"
passed to NotifyDone is now the full set of |last_requested_types_|
(as in all other NotifyDone call sites). Before, it was only the
|types_to_associate| in StartNextAssociation, which is a subset of the
full set of requested types (in particular, it's the least-important
set of types - most likely only the regular user types, without
priority types or control types). I'm 99% sure that was a bug.
(The "requested types" set is only consumed in BackendMigrator, which
hasn't been used in years, which is why this likely never mattered.)

Bug: 1102837
Change-Id: Ib1009bd31bc9dab4424859792a79a88ada82d0a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567217
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832754}