Google Git
Sign in
chromium / chromium / src / 7b2eafa70624e5ddc2f5a2ef566ee886bfbbbdb9
commit7b2eafa70624e5ddc2f5a2ef566ee886bfbbbdb9[log] [tgz]
authorIan Clelland <iclelland@chromium.org>Thu Sep 01 21:02:31 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 01 21:02:31 2022
treeba37b05f014274ae2e9c647cc4ea33bd3ff88521
parent4e9b1684e0f93c7115da96359dc119f5b84e9ced [diff]
Revert "[User Education] Add auto-dismiss timeout to WebUI IPH"

This reverts commit 4cee94e3366a080b5bcf8145dbbada46275ca33a.

Reason for revert: Fails tests on several builders:
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac11%20Tests/11166
https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/27050
https://ci.chromium.org/p/chromium/builders/ci/mac12-arm64-rel-tests/2058


Original change's description:
> [User Education] Add auto-dismiss timeout to WebUI IPH
>
> The HelpBubble will apply the given timeout or fallback to the default values. Default timeout logic is copied from Views IPH (with buttons = never, without buttons = 10s). Timeout gets to javascript as a BigInt and needs to be cast to Number. Timing out will now call HelpBubbleClosed in the HelpBubbleHandler.
>
> Mojo changes:
> - Pass TimeDelta through mojo for timeout
> - Add HelpBubbleClosedReason enum
> - Update HelpBubbleClosed to accept HelpBubbleClosedReason
>
>
> Bug: 1350594
> Change-Id: I7b6ae1802be5d44127e972dd5fe83859dbfc22e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838844
> Auto-Submit: Mickey Burks <mickeyburks@chromium.org>
> Reviewed-by: Joe Mason <joenotcharles@google.com>
> Reviewed-by: Dana Fried <dfried@chromium.org>
> Commit-Queue: Mickey Burks <mickeyburks@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1042190}

Bug: 1350594
Change-Id: I6070c76a68fea0ae842f7bdf21e874400614d7b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3864231
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Owners-Override: Ian Clelland <iclelland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1042299}
10 files changed
tree: ba37b05f014274ae2e9c647cc4ea33bd3ff88521
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.