commit | e692b51de3145467a8a820f8a24c3cbe994475d0 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Feb 20 17:17:33 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 20 17:17:33 2019 |
tree | 3ad1648712a7ca99172cdcacc6e6c9caf1674e99 | |
parent | 9bdad870f884c7dcaa74ff96aab1764f5eb1efdf [diff] |
Remove variable shadowing in blink/modules/webgl In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The warnings this avoids is: third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:3688:18: error: declaration shadows a local variable [-Werror,-Wshadow] unsigned length; ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:3658:13: note: previous declaration is here GLsizei length = 0; ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:5234:31: error: declaration shadows a local variable [-Werror,-Wshadow] ScopedTexture2DRestorer restorer(gl); ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:5190:27: note: previous declaration is here ScopedTexture2DRestorer restorer(this); Bug: 923510 Change-Id: Idef0b7f4b47aad7c0199d9e11571dc93d1c94429 Reviewed-on: https://chromium-review.googlesource.com/c/1477679 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#633750}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .