commit | e6d732e9056f1bd21fc51adef646dbc78822128d | [log] [tgz] |
---|---|---|
author | Xianzhu Wang <wangxianzhu@chromium.org> | Thu Dec 08 17:27:52 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 08 17:27:52 2022 |
tree | 240cbcf7d3ed2170cd790b54a951ca91f1dc711b | |
parent | 35906cf4097788e1564f3a2ef3d3928bbcd7d2d7 [diff] |
Split paint_op_buffer.h, preparing for making PaintOpBuffer not sk_sp Split paint_op_buffer.h into three headers: 1. paint_op.h 2. paint_op_buffer.h 3. paint_op_buffer_iterator.h 1 includes 2, and 3 includes 1 and 2. This makes it possible to let headers depended by paint_op.h to include paint_op_buffer.h in the future. For example, paint_op.h includes paint_image.h because PaintImageOp needs PaintImage, and PaintImage has a sk_sp<PaintRecord> field. With this change, we can change the sk_sp<PaintRecord> to PaintRecord which requires paint_image.h to include paint_record.h which includes paint_op_buffer.h, without creating a include circle. The future sk_sp<PaintRecord> removing change will reduce dynamic memory allocation for a PaintRecord from 2 (sk_sp and the internal buffer) to 1 (internal buffer only). Bug: 1385848 Change-Id: Ic23d52037fbf19e4fc0e91e9b95444f148093b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4087146 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Owners-Override: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1080972}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.