commit e70829163bbf8b9b3af83f057a69c07a0e57b8f9
author Daniel Rubery <drubery@chromium.org> Mon Mar 18 16:05:46 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 18 16:05:46 2024
tree 28897150a6fd1d5e51dd0e2b3f4eaf88438a6e76
parent cf1a3349fea82075ea6a95a324e8430a17f26d9a

Prepare to convert SBThreatType to an enum class in /components/blocked_content

It's somewhat difficult to log an SBThreatType as an UMA histogram since
we don't have a kMaxValue. We can't simply add a kMaxValue because
SBThreatType is an enum instead of enum class, and we'd be exposing a
constant safe_browsing::kMaxValue. This CL prepares to convert
SBThreatType to an enum class in /components/blocked_content.

That requires two changes:

- SBThreatType is no longer implicitly convertible to int, so we will
  need a few static casts

- SBThreatType values are now in the namespace
  safe_browsing::SBThreatType instead of just safe_browsing. In some
  places this is fixed by adding the new namespace, and in some places
  with a "using enum" declaration. We can't just add a "using enum" for
  all usages of SBThreatType because "using enum" would declare a
  constant kMaxValue. So "using enum" is only used when many
  SBThreatType constants are used, and in as narrow a scope as possible.

This CL was uploaded by git cl split.

Bug: 329698341
Change-Id: I23ffac4aee2d89ec4ff41d97e429c44337b8c255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5377021
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1274188}