Google Git
Sign in
chromium / chromium / src / e76385f619d9646738916082a485be1a23bdb436
commite76385f619d9646738916082a485be1a23bdb436[log] [tgz]
authorAdam Psarouthakis <psarouthakis@google.com>Tue Jun 25 16:16:08 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 25 16:16:08 2024
treef162116f9829bc3d3d6325076473e67af2b33406
parent93d802e79c87bb2584728c5fb4b8ef6d64eba9a8 [diff]
Extension Safety Hub Refactor Pref Migration

This CL deprecates the use of the boolean kPrefAcknowledgeSafetyCheckWarning pref which only stored whether
a safety check warning had been acknowledged by the user.

Instead, we will now rely only on the integer pref, kPrefAcknowledgeSafetyCheckWarningReason, which stores the specific warning that the user acknowledged.

The above changes require a migration logic that will be removed after a few milestones. The logic consists of:
- If only the boolean kPrefAcknowledgeSafetyCheckWarning pref is set,
  it is removed and the integer kPrefAcknowledgeSafetyCheckWarningReason
  pref is set to the current warning reason.
- If both kPrefAcknowledgeSafetyCheckWarning and
  kPrefAcknowledgeSafetyCheckWarningReason are set, the boolean
  pref is removed.

NOTES:
The code in this CL is not active and will be called in follow up CLs.
The setting of the old boolean pref, kPrefAcknowledgeSafetyCheckWarning, will also be removed in a follow up CL.

Bug: 335639105
Change-Id: I36058b52066c4f5a0fef1ab6ac65bc2a92a8f123
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639261
Reviewed-by: Anunoy Ghosh <anunoy@chromium.org>
Commit-Queue: Adam Psarouthakis <psarouthakis@google.com>
Cr-Commit-Position: refs/heads/main@{#1319195}
2 files changed
tree: f162116f9829bc3d3d6325076473e67af2b33406
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.