Initialize PasswordProtectionRequest::request_outcome_ to RequestOutcome::UNKNOWN In tests, the request mode is bound to the close callback in safe_browsing::ChromePasswordProtectionService::ShowModalWarning(). However, request mode is never initialized in tests, presumably because PasswordProtectionService::StartRequestForTesting() does not result in running the typical safe browsing flow. Unfortunately, passing an uninitialized value counts as a use for the purposes of C++, and using unininitialized values is undefined behavior. This was never detected in the past, because MSan only implemented these stricter checks with `msan_eager_checks=true`. Bug: 340729470 Change-Id: Iecf7a9304844704e8601046459b9e6f3033130ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539832 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1301372}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.