Google Git
Sign in
chromium / chromium / src / e7ad60a5304c2196e0123dcd7cee0804f7f317b1
commite7ad60a5304c2196e0123dcd7cee0804f7f317b1[log] [tgz]
authorginnnnnnny <ginnyhuang@chromium.org>Wed Jan 10 16:57:01 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 10 16:57:01 2024
tree537624caa4f119f7b1ad577927e416fedeacb1ed
parentebd5d501650b18aeb4c45a59a4343aaf64aaadc8 [diff]
[iOS] Add c++ observer for url loading

This CL adds a c++ observer class to observer URL loading. The class
added will be used in a subsequent CL.

To bring parity with other observer classes that have both C++ and Obj-C
implementations, the existing UrlLoadingObserver protocol is renamed to
`UrlLoadingObserving` so the postfix `Observer` would be left for the
C++ implementation.

The method signatures have also been updated so `const GURL&` replaces
GURL. This follows the best practise of go/totw/109 and also makes
testing with OCMock easier.

Bug: N/A
Change-Id: I41a79e6b60e912e6b9be8f01b341201f38bdffd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5173874
Auto-Submit: Ginny Huang <ginnyhuang@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Ginny Huang <ginnyhuang@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1245331}
10 files changed
tree: 537624caa4f119f7b1ad577927e416fedeacb1ed
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.