| commit | e7c7c2941f56f51497c385f95680d6ddf4c84b52 | [log] [tgz] |
|---|---|---|
| author | Yuki Shiino <yukishiino@chromium.org> | Sat Sep 19 19:36:20 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Sat Sep 19 19:36:20 2020 |
| tree | 2ed815e660e0e2d51682d72132964c5b053cf921 | |
| parent | a407643d00811e2049fa246f96e3d0465ef2cd36 [diff] |
v8binding: Clean up BFCache eviction hook
Currently LocalFrame::{Hook,Remove}BackForwardCacheEviction directly
manipulates the list of v8::Contexts, and it's a layering violation.
The list of available v8::Contexts are managed by WindowProxyManager,
so it should ask WindowProxyManager do the task, just like
UpdateSecurityOrigin is doing so.
This patch introduces LocalWindowProxyManager::
SetAbortScriptExecution just like UpdateSecurityOrigin.
In the past, the direct manipulation above caused a crash issue like
https://crbug.com/1117436 . This is the root fix.
Change-Id: I803c9495372aa02dcab59af107c91799f4e08ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420191
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808707}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.